mirror of
https://github.com/torvalds/linux.git
synced 2024-11-06 20:21:57 +00:00
e1000e: improper return code signage
The e1000_get_cable_length_82577() should return a negative value upon error. Signed-off-by: Bruce Allan <bruce.w.allan@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
7ea9655f8a
commit
98086a954a
@ -3137,7 +3137,7 @@ s32 e1000_get_cable_length_82577(struct e1000_hw *hw)
|
||||
I82577_DSTATUS_CABLE_LENGTH_SHIFT;
|
||||
|
||||
if (length == E1000_CABLE_LENGTH_UNDEFINED)
|
||||
ret_val = E1000_ERR_PHY;
|
||||
ret_val = -E1000_ERR_PHY;
|
||||
|
||||
phy->cable_length = length;
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user