Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-26 22:21:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

mfd: intel-lpss: Return error code received from the IRQ API

Browse Source 
platform_get_irq() returns a negative error code to indicate an error.
As does pci_alloc_irq_vectors() and pci_irq_vector(). So in
intel_lpss_probe() the erroneous IRQ would be better returned as is.

The pci_alloc_irq_vectors() call and platform_get_irq() guarantee
that IRQs will not be 0, so we'll drop that check as well.

Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
[andy: updated commit message]
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20231106184052.1166579-3-andriy.shevchenko@linux.intel.com
Signed-off-by: Lee Jones <lee@kernel.org>
This commit is contained in:
Chen Ni 2023-11-06 20:40:52 +02:00 committed by Lee Jones
parent 6978c7d2dd
commit 92827c1020
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/mfd/intel-lpss.c
View File

@ -378,9 +378,12 @@ int intel_lpss_probe(struct device *dev,
struct intel_lpss *lpss; struct intel_lpss *lpss;
int ret; int ret;
if (!info || !info->mem || info->irq <= 0) if (!info || !info->mem)
return -EINVAL; return -EINVAL;
if (info->irq < 0)
return info->irq;
lpss = devm_kzalloc(dev, sizeof(*lpss), GFP_KERNEL); lpss = devm_kzalloc(dev, sizeof(*lpss), GFP_KERNEL);
if (!lpss) if (!lpss)
return -ENOMEM; return -ENOMEM;