From 8fe0c2c2cb7be631576637555d712247bc86f1bf Mon Sep 17 00:00:00 2001 From: Steve French Date: Fri, 28 Feb 2020 01:32:37 -0600 Subject: [PATCH] cifs: print warning mounting with vers=1.0 We really, really don't want people using insecure dialects unless they realize what they are doing ... Add mount warning if mounting with vers=1.0 (older SMB1/CIFS dialect) instead of the default (SMB2.1 or later, typically SMB3.1.1). Signed-off-by: Steve French Acked-by: Ronnie Sahlberg Acked-by: Pavel Shilovsky --- fs/cifs/connect.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c index f4d12b79ceed..46b602dfc4d3 100644 --- a/fs/cifs/connect.c +++ b/fs/cifs/connect.c @@ -1471,6 +1471,9 @@ cifs_parse_smb_version(char *value, struct smb_vol *vol, bool is_smb3) cifs_dbg(VFS, "vers=1.0 (cifs) not permitted when mounting with smb3\n"); return 1; } + cifs_dbg(VFS, "Use of the less secure dialect vers=1.0 " + "is not recommended unless required for " + "access to very old servers\n"); vol->ops = &smb1_operations; vol->vals = &smb1_values; break;