Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-26 14:12:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

XFRM: Fix memory leak in xfrm_state_update

Browse Source 
Upon "ip xfrm state update ..", xfrm_add_sa() takes an extra reference on
the user-supplied SA and forgets to drop the reference when
xfrm_state_update() returns 0.  This leads to a memory leak as the
parameter SA is never freed.  This change attempts to fix the leak by
calling __xfrm_state_put() when xfrm_state_update() updates a valid SA
(err = 0).  The parameter SA is added to the gc list when the final
reference is dropped by xfrm_add_sa() upon completion.

Signed-off-by: Tushar Gohad <tgohad@mvista.com>
Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Tushar Gohad 2011-07-07 15:38:52 +00:00 committed by David S. Miller
parent f8d9605243
commit 8fcbc63701
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
net/xfrm/xfrm_state.c
View File

@ -1345,6 +1345,8 @@ out:
xfrm_state_check_expire(x1); xfrm_state_check_expire(x1);
err = 0; err = 0;
x->km.state = XFRM_STATE_DEAD;
__xfrm_state_put(x);
} }
spin_unlock_bh(&x1->lock); spin_unlock_bh(&x1->lock);