Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-24 21:21:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

rtc: stk17ta8: fix possible race condition

Browse Source 
The probe function is not allowed to fail after registering the RTC. Call
rtc_register_device() at the end.

Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
This commit is contained in:
Alexandre Belloni 2018-02-12 23:47:53 +01:00
parent 91cb6774f6
commit 8d3e6b55ce
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/rtc/rtc-stk17ta8.c
View File

@ -334,11 +334,11 @@ static int stk17ta8_rtc_probe(struct platform_device *pdev)
pdata->rtc->ops = &stk17ta8_rtc_ops;
ret = rtc_register_device(pdata->rtc);
ret = sysfs_create_bin_file(&pdev->dev.kobj, &stk17ta8_nvram_attr);
if (ret)
return ret;
ret = sysfs_create_bin_file(&pdev->dev.kobj, &stk17ta8_nvram_attr);
ret = rtc_register_device(pdata->rtc);
return ret;
}