Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-05 19:41:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

intel_mid_dma: fix the WARN_ONs

Browse Source 
Moved the WARN_ON to BUG_ON, as WARN_ON if hit,
can cause null pointer derefrences

Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
This commit is contained in:
Koul, Vinod 2010-10-04 10:38:25 +00:00 committed by Dan Williams
parent 576e3c394a
commit 8b6492231d
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/dma/intel_mid_dma.c
View File

@ -581,15 +581,15 @@ static struct dma_async_tx_descriptor *intel_mid_dma_prep_memcpy(
enum intel_mid_dma_width width = 0; enum intel_mid_dma_width width = 0;
pr_debug("MDMA: Prep for memcpy\n"); pr_debug("MDMA: Prep for memcpy\n");
WARN_ON(!chan); BUG_ON(!chan);
if (!len) if (!len)
return NULL; return NULL;
mids = chan->private; mids = chan->private;
WARN_ON(!mids); BUG_ON(!mids);
midc = to_intel_mid_dma_chan(chan); midc = to_intel_mid_dma_chan(chan);
WARN_ON(!midc); BUG_ON(!midc);
pr_debug("MDMA:called for DMA %x CH %d Length %zu\n", pr_debug("MDMA:called for DMA %x CH %d Length %zu\n",
midc->dma->pci_id, midc->ch_id, len); midc->dma->pci_id, midc->ch_id, len);