Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-21 19:41:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

io_uring/uring_cmd: get rid of using req->imu

Browse Source 
It's pretty pointless to use io_kiocb as intermediate storage for this,
so split the validity check and the actual usage. The resource node is
assigned upfront at prep time, to prevent it from going away. The actual
import is never called with the ctx->uring_lock held, so grab it for
the import.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
This commit is contained in:
Jens Axboe 2024-10-16 15:48:38 -06:00
parent c919790060
commit 892d3e80e1
1 changed files with 18 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
io_uring/uring_cmd.c
View File

@ -211,11 +211,15 @@ int io_uring_cmd_prep(struct io_kiocb *req, const struct io_uring_sqe *sqe)
struct io_ring_ctx *ctx = req->ctx;
u16 index;
req->buf_index = READ_ONCE(sqe->buf_index);
if (unlikely(req->buf_index >= ctx->nr_user_bufs))
index = READ_ONCE(sqe->buf_index);
if (unlikely(index >= ctx->nr_user_bufs))
return -EFAULT;
index = array_index_nospec(req->buf_index, ctx->nr_user_bufs);
req->imu = ctx->user_bufs[index];
req->buf_index = array_index_nospec(index, ctx->nr_user_bufs);
/*
* Pi node upfront, prior to io_uring_cmd_import_fixed()
* being called. This prevents destruction of the mapped buffer
* we'll need at actual import time.
*/
io_req_set_rsrc_node(req, ctx, 0);
}
ioucmd->cmd_op = READ_ONCE(sqe->cmd_op);
@ -272,8 +276,17 @@ int io_uring_cmd_import_fixed(u64 ubuf, unsigned long len, int rw,
struct iov_iter *iter, void *ioucmd)
{
struct io_kiocb *req = cmd_to_io_kiocb(ioucmd);
struct io_ring_ctx *ctx = req->ctx;
return io_import_fixed(rw, iter, req->imu, ubuf, len);
/* Must have had rsrc_node assigned at prep time */
if (req->rsrc_node) {
struct io_mapped_ubuf *imu;
imu = READ_ONCE(ctx->user_bufs[req->buf_index]);
return io_import_fixed(rw, iter, imu, ubuf, len);
}
return -EFAULT;
}
EXPORT_SYMBOL_GPL(io_uring_cmd_import_fixed);