Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-12-05 18:41:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

RDMA/siw: Remove unnecessary kthread create/destroy printouts

Browse Source 
There is already a warning if we cannot start any thread, and stopping
those threads is not worth spamming the console.

This also corrects a warning from gcc:

 drivers/infiniband/sw/siw/siw_main.c: In function 'siw_create_tx_threads':
 drivers/infiniband/sw/siw/siw_main.c:91:11: warning:
  variable 'rv' set but not used [-Wunused-but-set-variable]

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: Bernard Metzler <bmt@zurich.ibm.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
This commit is contained in:
Bernard Metzler 2019-07-10 08:38:00 +00:00 committed by Jason Gunthorpe
parent 4d2b8517ba
commit 85de5d5336
2 changed files with 1 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/infiniband/sw/siw/siw_main.c
View File

@ -88,7 +88,7 @@ static void siw_device_cleanup(struct ib_device *base_dev)
static int siw_create_tx_threads(void) static int siw_create_tx_threads(void)
{ {
int cpu, rv, assigned = 0; int cpu, assigned = 0;
for_each_online_cpu(cpu) { for_each_online_cpu(cpu) {
/* Skip HT cores */ /* Skip HT cores */
@ -99,9 +99,7 @@ static int siw_create_tx_threads(void)
kthread_create(siw_run_sq, (unsigned long *)(long)cpu, kthread_create(siw_run_sq, (unsigned long *)(long)cpu,
"siw_tx/%d", cpu); "siw_tx/%d", cpu);
if (IS_ERR(siw_tx_thread[cpu])) { if (IS_ERR(siw_tx_thread[cpu])) {
rv = PTR_ERR(siw_tx_thread[cpu]);
siw_tx_thread[cpu] = NULL; siw_tx_thread[cpu] = NULL;
pr_info("Creating TX thread for CPU %d failed", cpu);
continue; continue;
} }
kthread_bind(siw_tx_thread[cpu], cpu); kthread_bind(siw_tx_thread[cpu], cpu);

4
drivers/infiniband/sw/siw/siw_qp_tx.c
View File

@ -1201,8 +1201,6 @@ int siw_run_sq(void *data)
init_llist_head(&tx_task->active); init_llist_head(&tx_task->active);
init_waitqueue_head(&tx_task->waiting); init_waitqueue_head(&tx_task->waiting);
pr_info("Started siw TX thread on CPU %u\n", nr_cpu);
while (1) { while (1) {
struct llist_node *fifo_list = NULL; struct llist_node *fifo_list = NULL;
@ -1240,8 +1238,6 @@ int siw_run_sq(void *data)
siw_sq_resume(qp); siw_sq_resume(qp);
} }
} }
pr_info("Stopped siw TX thread on CPU %u\n", nr_cpu);
return 0; return 0;
} }