Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-29 23:51:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

perf test: Remove is_supported function

Browse Source 
All tests now return TEST_SKIP if not supported. Removing this function
brings perf's test_suite struct more inline with kunit.

Signed-off-by: Ian Rogers <irogers@google.com>
Tested-by: Sohaib Mohamed <sohaib.amhmd@gmail.com>
Acked-by: Jiri Olsa <jolsa@redhat.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Brendan Higgins <brendanhiggins@google.com>
Cc: Daniel Latypov <dlatypov@google.com>
Cc: David Gow <davidgow@google.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jin Yao <yao.jin@linux.intel.com>
Cc: John Garry <john.garry@huawei.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Paul Clarke <pc@us.ibm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Link: https://lore.kernel.org/r/20211104064208.3156807-22-irogers@google.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
This commit is contained in:
Ian Rogers 2021-11-03 23:42:07 -07:00 committed by Arnaldo Carvalho de Melo
parent e74dd9cb33
commit 848ddf5999
2 changed files with 1 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
tools/perf/tests/builtin-test.c
View File

@ -150,11 +150,6 @@ static const char *test_description(const struct test_suite *t, int subtest)
return t->desc;
}
static bool is_supported(const struct test_suite *t)
{
return !t->is_supported || t->is_supported();
}
static test_fnptr test_function(const struct test_suite *t, int subtest)
{
if (subtest <= 0)
@ -480,12 +475,6 @@ static int __cmd_test(int argc, const char *argv[], struct intlist *skiplist)
continue;
}
if (!is_supported(t)) {
pr_debug("%2d: %-*s: Disabled\n", i, width,
test_description(t, -1));
continue;
}
pr_info("%2d: %-*s:", i, width, test_description(t, -1));
if (intlist__find(skiplist, i)) {
@ -583,8 +572,7 @@ static int perf_test__list(int argc, const char **argv)
for_each_test(j, k, t) {
int curr = i++;
if (!perf_test__matches(test_description(t, -1), curr, argc, argv) ||
!is_supported(t))
if (!perf_test__matches(test_description(t, -1), curr, argc, argv))
continue;
pr_info("%2d: %s\n", i, test_description(t, -1));

1
tools/perf/tests/tests.h
View File

@ -44,7 +44,6 @@ struct test_suite {
bool skip_if_fail;
} subtest;
struct test_case *test_cases;
bool (*is_supported)(void);
void *priv;
};