Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-10-24 06:01:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

staging: unisys: visorhba: main path needs to flow down the left margin

Browse Source 
In del_scsipending_ent(), the error-path and main-path were switched, so
the error-path is handled like 'if (err) return;', and the main-path flows
down the left margin.  This also allowed us to remove the initialization of
"sent".

Signed-off-by: Tim Sell <Timothy.Sell@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Tim Sell 2016-05-06 13:11:22 -04:00 committed by Greg Kroah-Hartman
parent 73ba8afe33
commit 825157aeda
1 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
drivers/staging/unisys/visorhba/visorhba_main.c
View File

@ -235,16 +235,17 @@ static void *del_scsipending_ent(struct visorhba_devdata *devdata,
int del)
{
unsigned long flags;
void *sent = NULL;
void *sent;
if (del < MAX_PENDING_REQUESTS) {
spin_lock_irqsave(&devdata->privlock, flags);
sent = devdata->pending[del].sent;
if (del >= MAX_PENDING_REQUESTS)
return NULL;
devdata->pending[del].cmdtype = 0;
devdata->pending[del].sent = NULL;
spin_unlock_irqrestore(&devdata->privlock, flags);
}
spin_lock_irqsave(&devdata->privlock, flags);
sent = devdata->pending[del].sent;
devdata->pending[del].cmdtype = 0;
devdata->pending[del].sent = NULL;
spin_unlock_irqrestore(&devdata->privlock, flags);
return sent;
}