Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-23 12:42:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

md:raid1: fix a dead loop when read from a WriteMostly disk

Browse Source 
If first_bad == this_sector when we get the WriteMostly disk
in read_balance(), valid disk will be returned with zero
max_sectors. It'll lead to a dead loop in make_request(), and
OOM will happen because of endless allocation of struct bio.

Since we can't get data from this disk in this case, so
continue for another disk.

Signed-off-by: Wei Fang <fangwei1@huawei.com>
Signed-off-by: Shaohua Li <shli@fb.com>
This commit is contained in:
Wei Fang 2016-03-21 19:18:32 +08:00 committed by Shaohua Li
parent c05c2ec96b
commit 816b0acf3d
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/md/raid1.c
View File

@ -570,7 +570,7 @@ static int read_balance(struct r1conf *conf, struct r1bio *r1_bio, int *max_sect
if (best_dist_disk < 0) { if (best_dist_disk < 0) {
if (is_badblock(rdev, this_sector, sectors, if (is_badblock(rdev, this_sector, sectors,
&first_bad, &bad_sectors)) { &first_bad, &bad_sectors)) {
if (first_bad < this_sector) if (first_bad <= this_sector)
/* Cannot use this */ /* Cannot use this */
continue; continue;
best_good_sectors = first_bad - this_sector; best_good_sectors = first_bad - this_sector;