Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-12-19 17:41:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

net: nixge: let core reject the unsupported coalescing parameters

Browse Source 
Set ethtool_ops->supported_coalesce_params to let
the core reject unsupported coalescing parameters.

This driver correctly rejects all unsupported
parameters, no functional changes.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Jakub Kicinski 2020-03-12 21:07:57 -07:00 committed by David S. Miller
parent 930129d9d8
commit 8078f028de
1 changed files with 1 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
drivers/net/ethernet/ni/nixge.c
View File

@ -1019,27 +1019,6 @@ static int nixge_ethtools_set_coalesce(struct net_device *ndev,
return -EBUSY;
}
if (ecoalesce->rx_coalesce_usecs ||
ecoalesce->rx_coalesce_usecs_irq ||
ecoalesce->rx_max_coalesced_frames_irq ||
ecoalesce->tx_coalesce_usecs ||
ecoalesce->tx_coalesce_usecs_irq ||
ecoalesce->tx_max_coalesced_frames_irq ||
ecoalesce->stats_block_coalesce_usecs ||
ecoalesce->use_adaptive_rx_coalesce ||
ecoalesce->use_adaptive_tx_coalesce ||
ecoalesce->pkt_rate_low ||
ecoalesce->rx_coalesce_usecs_low ||
ecoalesce->rx_max_coalesced_frames_low ||
ecoalesce->tx_coalesce_usecs_low ||
ecoalesce->tx_max_coalesced_frames_low ||
ecoalesce->pkt_rate_high ||
ecoalesce->rx_coalesce_usecs_high ||
ecoalesce->rx_max_coalesced_frames_high ||
ecoalesce->tx_coalesce_usecs_high ||
ecoalesce->tx_max_coalesced_frames_high ||
ecoalesce->rate_sample_interval)
return -EOPNOTSUPP;
if (ecoalesce->rx_max_coalesced_frames)
priv->coalesce_count_rx = ecoalesce->rx_max_coalesced_frames;
if (ecoalesce->tx_max_coalesced_frames)
@ -1083,6 +1062,7 @@ static int nixge_ethtools_set_phys_id(struct net_device *ndev,
}
static const struct ethtool_ops nixge_ethtool_ops = {
.supported_coalesce_params = ETHTOOL_COALESCE_MAX_FRAMES,
.get_drvinfo = nixge_ethtools_get_drvinfo,
.get_coalesce = nixge_ethtools_get_coalesce,
.set_coalesce = nixge_ethtools_set_coalesce,