Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-24 13:11:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

ieee1394: fix oops on "modprobe -r ohci1394" after network class_device conversion

Browse Source 
The networking subsystem has been converted from class_device to device
but ieee1394 hasn't.  This results in a 100% reproducible NULL pointer
dereference if the ohci1394 driver module is unloaded while the eth1394
module is still loaded.
http://lkml.org/lkml/2006/11/16/147
http://lkml.org/lkml/2007/3/14/4

This is a regression in 2.6.21-rc1.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Tested-by: Ismail Dönmez <ismail@pardus.org.tr>
This commit is contained in:
Stefan Richter 2007-03-20 22:43:22 +01:00
parent 12998096cc
commit 7a9eeb2fa1
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/ieee1394/eth1394.c
View File

@ -584,7 +584,10 @@ static void ether1394_add_host (struct hpsb_host *host)
}
SET_MODULE_OWNER(dev);
#if 0
/* FIXME - Is this the correct parent device anyway? */
SET_NETDEV_DEV(dev, &host->device);
#endif
priv = netdev_priv(dev);