mirror of
https://github.com/torvalds/linux.git
synced 2024-11-22 12:11:40 +00:00
eventfs: Remove extra dget() in eventfs_create_events_dir()
The creation of the top events directory does a dget() at the end of the
creation in eventfs_create_events_dir() with a comment saying the final
dput() will happen when it is removed. The problem is that a dget() is
already done on the dentry when it was created with tracefs_start_creating()!
The dget() now just causes a memory leak of that dentry.
Remove the extra dget() as the final dput() in the deletion of the events
directory actually matches the one in tracefs_start_creating().
Link: https://lore.kernel.org/linux-trace-kernel/20231031124229.4f2e3fa1@gandalf.local.home
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Fixes: 5790b1fb3d
("eventfs: Remove eventfs_file and just use eventfs_inode")
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
This commit is contained in:
parent
bb32500fb9
commit
77bc4d4921
@ -774,9 +774,6 @@ struct eventfs_inode *eventfs_create_events_dir(const char *name, struct dentry
|
||||
fsnotify_mkdir(dentry->d_parent->d_inode, dentry);
|
||||
tracefs_end_creating(dentry);
|
||||
|
||||
/* Will call dput when the directory is removed */
|
||||
dget(dentry);
|
||||
|
||||
return ei;
|
||||
|
||||
fail:
|
||||
|
Loading…
Reference in New Issue
Block a user