mirror of
https://github.com/torvalds/linux.git
synced 2024-12-04 01:51:34 +00:00
media: s5k5baf: drop 'data' field in struct s5k5baf_fw
struct s5k5baf_fw ends with this: struct { u16 id; u16 offset; } seq[0]; u16 data[]; }; which is rather confusing and can cause gcc warnings: s5k5baf.c: In function 's5k5baf_load_setfile.isra': s5k5baf.c:390:13: warning: array subscript 65535 is outside the bounds of an interior zero-length array 'struct <anonymous>[0]' [-Wzero-length-bounds] 390 | if (f->seq[i].offset + d <= end) | ~~~~~~^~~ It turns out that 'data[]' is used in only one place and it can easily be replaced by &fw->seq[0].id and 'seq[0]' can be replaced by 'seq[]'. This is both more readable and solved that warnings. Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Cc: Kyungmin Park <kyungmin.park@samsung.com> Cc: Sylwester Nawrocki <snawrocki@kernel.org> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
This commit is contained in:
parent
5b380f242f
commit
7124ae48f2
@ -280,8 +280,7 @@ struct s5k5baf_fw {
|
||||
struct {
|
||||
u16 id;
|
||||
u16 offset;
|
||||
} seq[0];
|
||||
u16 data[];
|
||||
} seq[];
|
||||
};
|
||||
|
||||
struct s5k5baf {
|
||||
@ -563,7 +562,7 @@ static u16 *s5k5baf_fw_get_seq(struct s5k5baf *state, u16 seq_id)
|
||||
if (fw == NULL)
|
||||
return NULL;
|
||||
|
||||
data = fw->data + 2 * fw->count;
|
||||
data = &fw->seq[0].id + 2 * fw->count;
|
||||
|
||||
for (i = 0; i < fw->count; ++i) {
|
||||
if (fw->seq[i].id == seq_id)
|
||||
|
Loading…
Reference in New Issue
Block a user