Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-10-30 08:42:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

USB: serial: io_ti: fix div-by-zero in set_termios

Browse Source 
Fix a division-by-zero in set_termios when debugging is enabled and a
high-enough speed has been requested so that the divisor value becomes
zero.

Instead of just fixing the offending debug statement, cap the baud rate
at the base as a zero divisor value also appears to crash the firmware.

Fixes: 1da177e4c3 ("Linux-2.6.12-rc2")
Cc: stable <stable@vger.kernel.org>     # 2.6.12
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
This commit is contained in:
Johan Hovold 2017-05-11 11:41:21 +02:00
parent 26cede3436
commit 6aeb75e6ad
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/usb/serial/io_ti.c
View File

@ -2336,8 +2336,11 @@ static void change_port_settings(struct tty_struct *tty,
if (!baud) { if (!baud) {
/* pick a default, any default... */ /* pick a default, any default... */
baud = 9600; baud = 9600;
} else } else {
/* Avoid a zero divisor. */
baud = min(baud, 461550);
tty_encode_baud_rate(tty, baud, baud); tty_encode_baud_rate(tty, baud, baud);
}
edge_port->baud_rate = baud; edge_port->baud_rate = baud;
config->wBaudRate = (__u16)((461550L + baud/2) / baud); config->wBaudRate = (__u16)((461550L + baud/2) / baud);