Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-26 06:02:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

rtc: cmos: Replace spin_lock_irqsave with spin_lock in hard IRQ

Browse Source 
It is redundant to do irqsave and irqrestore in hardIRQ context, where
it has been in a irq-disabled context.

Signed-off-by: Xiaofei Tan <tanxiaofei@huawei.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Link: https://lore.kernel.org/r/1612355981-6764-2-git-send-email-tanxiaofei@huawei.com
This commit is contained in:
Xiaofei Tan 2021-02-03 20:39:36 +08:00 committed by Alexandre Belloni
parent ddd0521549
commit 6950d046eb
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/rtc/rtc-cmos.c
View File

@ -643,11 +643,10 @@ static struct cmos_rtc cmos_rtc;
static irqreturn_t cmos_interrupt(int irq, void *p) static irqreturn_t cmos_interrupt(int irq, void *p)
{ {
unsigned long flags;
u8 irqstat; u8 irqstat;
u8 rtc_control; u8 rtc_control;
spin_lock_irqsave(&rtc_lock, flags); spin_lock(&rtc_lock);
/* When the HPET interrupt handler calls us, the interrupt /* When the HPET interrupt handler calls us, the interrupt
* status is passed as arg1 instead of the irq number. But * status is passed as arg1 instead of the irq number. But
@ -681,7 +680,7 @@ static irqreturn_t cmos_interrupt(int irq, void *p)
hpet_mask_rtc_irq_bit(RTC_AIE); hpet_mask_rtc_irq_bit(RTC_AIE);
CMOS_READ(RTC_INTR_FLAGS); CMOS_READ(RTC_INTR_FLAGS);
} }
spin_unlock_irqrestore(&rtc_lock, flags); spin_unlock(&rtc_lock);
if (is_intr(irqstat)) { if (is_intr(irqstat)) {
rtc_update_irq(p, 1, irqstat); rtc_update_irq(p, 1, irqstat);