From 66f308ed7dab1b3460d186a794e1f9c2d229f709 Mon Sep 17 00:00:00 2001 From: Yisheng Xie Date: Wed, 31 Jan 2018 16:16:07 -0800 Subject: [PATCH] mm/mempolicy: remove redundant check in get_nodes We have already checked whether maxnode is a page worth of bits, by: maxnode > PAGE_SIZE*BITS_PER_BYTE So no need to check it once more. Link: http://lkml.kernel.org/r/1510882624-44342-2-git-send-email-xieyisheng1@huawei.com Signed-off-by: Yisheng Xie Acked-by: Vlastimil Babka Acked-by: David Rientjes Cc: Ingo Molnar Cc: David Rientjes Cc: Naoya Horiguchi Cc: Chris Salls Cc: Andi Kleen Cc: Christopher Lameter Cc: Tan Xiaojun Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- mm/mempolicy.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/mm/mempolicy.c b/mm/mempolicy.c index 4ce44d3ff03d..6e867a8dcca9 100644 --- a/mm/mempolicy.c +++ b/mm/mempolicy.c @@ -1282,8 +1282,6 @@ static int get_nodes(nodemask_t *nodes, const unsigned long __user *nmask, /* When the user specified more nodes than supported just check if the non supported part is all zero. */ if (nlongs > BITS_TO_LONGS(MAX_NUMNODES)) { - if (nlongs > PAGE_SIZE/sizeof(long)) - return -EINVAL; for (k = BITS_TO_LONGS(MAX_NUMNODES); k < nlongs; k++) { unsigned long t; if (get_user(t, nmask + k))