mirror of
https://github.com/torvalds/linux.git
synced 2024-12-10 05:01:26 +00:00
usb: host: ehci-tegra: Correct teardown order of driver's removal
I found that PHY's enable refcounting was broken and after fixing it I also found that machine started to hang after EHCI driver module removal. Turned out that the teardown order is incorrect because HCD must be unregistered *before* PHY's disabling. Note that it is also not correct to assert the shared reset during of driver's removal because PHY takes care of resetting shared pads and thus it's better to remove that part from the EHCI driver. Signed-off-by: Dmitry Osipenko <digetx@gmail.com> Acked-by: Alan Stern <stern@rowland.harvard.edu> Link: https://lore.kernel.org/r/20200106013416.9604-3-digetx@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
0bb207acd3
commit
62a7f62891
@ -521,16 +521,10 @@ static int tegra_ehci_remove(struct platform_device *pdev)
|
||||
struct tegra_ehci_hcd *tegra =
|
||||
(struct tegra_ehci_hcd *)hcd_to_ehci(hcd)->priv;
|
||||
|
||||
otg_set_host(hcd->usb_phy->otg, NULL);
|
||||
|
||||
usb_phy_shutdown(hcd->usb_phy);
|
||||
usb_remove_hcd(hcd);
|
||||
|
||||
reset_control_assert(tegra->rst);
|
||||
udelay(1);
|
||||
|
||||
otg_set_host(hcd->usb_phy->otg, NULL);
|
||||
usb_phy_shutdown(hcd->usb_phy);
|
||||
clk_disable_unprepare(tegra->clk);
|
||||
|
||||
usb_put_hcd(hcd);
|
||||
|
||||
return 0;
|
||||
|
Loading…
Reference in New Issue
Block a user