Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-08 05:01:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

team: Replace rcu_read_lock with a mutex in team_vlan_rx_kill_vid

Browse Source 
We can't be within an RCU read-side critical section when deleting
VLANs, as underlying drivers might sleep during the hardware operation.
Therefore, replace the RCU critical section with a mutex. This is
consistent with team_vlan_rx_add_vid.

Fixes: 3d249d4ca7 ("net: introduce ethernet teaming device")
Acked-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Ido Schimmel 2016-01-18 17:30:22 +02:00 committed by David S. Miller
parent 918f618f56
commit 60a6531bfe
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/net/team/team.c
View File

@ -1872,10 +1872,10 @@ static int team_vlan_rx_kill_vid(struct net_device *dev, __be16 proto, u16 vid)
struct team *team = netdev_priv(dev); struct team *team = netdev_priv(dev);
struct team_port *port; struct team_port *port;
rcu_read_lock(); mutex_lock(&team->lock);
list_for_each_entry_rcu(port, &team->port_list, list) list_for_each_entry(port, &team->port_list, list)
vlan_vid_del(port->dev, proto, vid); vlan_vid_del(port->dev, proto, vid);
rcu_read_unlock(); mutex_unlock(&team->lock);
return 0; return 0;
} }