tools/lib/lockdep/tests: Improve testing accuracy

Instead of checking whether the tests produced any output, check the
output itself. This patch avoids that e.g. debug output causes the
message "PASSED!" to be reported for failed tests.

Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Johannes Berg <johannes@sipsolutions.net>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Sasha Levin <sasha.levin@oracle.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Waiman Long <longman@redhat.com>
Cc: johannes.berg@intel.com
Cc: tj@kernel.org
Link: https://lkml.kernel.org/r/20181207011148.251812-4-bvanassche@acm.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
This commit is contained in:
Bart Van Assche 2018-12-06 17:11:27 -08:00 committed by Ingo Molnar
parent 7e9798871a
commit 5ecb8e94b4
12 changed files with 25 additions and 2 deletions

View File

@ -11,7 +11,7 @@ find tests -name '*.c' | sort | while read -r i; do
testname=$(basename "$i" .c)
echo -ne "$testname... "
if gcc -o "tests/$testname" -pthread "$i" liblockdep.a -Iinclude -D__USE_LIBLOCKDEP &&
[ "$(timeout 1 "./tests/$testname" 2>&1 | wc -l)" -gt 0 ]; then
timeout 1 "tests/$testname" 2>&1 | "tests/${testname}.sh"; then
echo "PASSED!"
else
echo "FAILED!"
@ -23,7 +23,8 @@ find tests -name '*.c' | sort | while read -r i; do
testname=$(basename "$i" .c)
echo -ne "(PRELOAD) $testname... "
if gcc -o "tests/$testname" -pthread -Iinclude "$i" &&
[ "$(timeout 1 ./lockdep "./tests/$testname" 2>&1 | wc -l)" -gt 0 ]; then
timeout 1 ./lockdep "tests/$testname" 2>&1 |
"tests/${testname}.sh"; then
echo "PASSED!"
else
echo "FAILED!"

View File

@ -0,0 +1,2 @@
#!/bin/bash
grep -q 'WARNING: possible recursive locking detected'

View File

@ -0,0 +1,2 @@
#!/bin/bash
grep -q 'WARNING: possible recursive locking detected'

View File

@ -0,0 +1,2 @@
#!/bin/bash
grep -q 'WARNING: possible circular locking dependency detected'

View File

@ -0,0 +1,2 @@
#!/bin/bash
grep -q 'WARNING: possible circular locking dependency detected'

View File

@ -0,0 +1,2 @@
#!/bin/bash
grep -q 'WARNING: possible circular locking dependency detected'

View File

@ -0,0 +1,2 @@
#!/bin/bash
grep -q 'WARNING: possible circular locking dependency detected'

View File

@ -0,0 +1,2 @@
#!/bin/bash
grep -q 'WARNING: possible circular locking dependency detected'

View File

@ -0,0 +1,2 @@
#!/bin/bash
grep -q 'WARNING: possible circular locking dependency detected'

View File

@ -0,0 +1,2 @@
#!/bin/bash
grep -q 'WARNING: possible circular locking dependency detected'

View File

@ -0,0 +1,2 @@
#!/bin/bash
grep -q 'WARNING: possible recursive locking detected'

View File

@ -0,0 +1,2 @@
#!/bin/bash
grep -q 'WARNING: bad unlock balance detected'