From 5e40508e5fee2dac7b04d5bc5b5ef3b452f0a899 Mon Sep 17 00:00:00 2001 From: Akinobu Mita Date: Fri, 22 Dec 2006 01:10:28 -0800 Subject: [PATCH] [PATCH] tlclk: delete unnecessary sysfs_remove_group It is unnecessary and invalid to call sysfs_remove_group() after sysfs_create_group() failure. Cc: Sebastien Bouchard Cc: Mark Gross Signed-off-by: Akinobu Mita Cc: Greg KH Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- drivers/char/tlclk.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/char/tlclk.c b/drivers/char/tlclk.c index 244d30a03fef..448d5083c381 100644 --- a/drivers/char/tlclk.c +++ b/drivers/char/tlclk.c @@ -807,8 +807,6 @@ static int __init tlclk_init(void) &tlclk_attribute_group); if (ret) { printk(KERN_ERR "tlclk: failed to create sysfs device attributes.\n"); - sysfs_remove_group(&tlclk_device->dev.kobj, - &tlclk_attribute_group); goto out5; }