Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-01 17:51:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

staging: usbip: Process event flags without delay

Browse Source 
The way the event handler works can cause it to delay
events until eventual wakeup for another event.

For example, on device detach (vhci):

 - Write to sysfs detach file
    -> usbip_event_add(VDEV_EVENT_DOWN)
      -> wakeup()

#define VDEV_EVENT_DOWN (USBIP_EH_SHUTDOWN | USBIP_EH_RESET).

 - Event thread wakes up and passes the event to
   event_handler() to process.

 - It processes and clears the USBIP_EH_SHUTDOWN
   flag then returns.

 - The outer event loop (event_handler_loop()) calls
   wait_event_interruptible().

The processing of the second flag which is part of
VDEV_EVENT_DOWN (USBIP_EH_RESET) did not happen yet.
It is delayed until the next event.

This means the ->reset callback may not happen for
a long time (if ever), leaving the usbip port in a
weird state which prevents its reuse.

This patch changes the handler to process all flags
before waiting for another wakeup.

I have verified this change to fix a problem which
prevented reattach of a usbip device. It also helps
for socket errors which missed the RESET as well.

The delayed event processing also affects the stub
side of usbip and the error handling there.

Signed-off-by: Max Vozeler <mvz@vozeler.com>
Reported-by: Marco Lancione <marco@optikam.com>
Tested-by: Luc Jalbert <ljalbert@optikam.com>
Cc: stable <stable@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Max Vozeler 2010-09-21 17:43:30 +02:00 committed by Greg Kroah-Hartman
parent 0c9a32f019
commit 584c5b7cf0
1 changed files with 3 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
drivers/staging/usbip/usbip_event.c
View File

@ -38,21 +38,13 @@ static int event_handler(struct usbip_device *ud)
ud->eh_ops.shutdown(ud); ud->eh_ops.shutdown(ud);
ud->event &= ~USBIP_EH_SHUTDOWN; ud->event &= ~USBIP_EH_SHUTDOWN;
break;
} }
/* Stop the error handler. */
if (ud->event & USBIP_EH_BYE)
return -1;
/* Reset the device. */ /* Reset the device. */
if (ud->event & USBIP_EH_RESET) { if (ud->event & USBIP_EH_RESET) {
ud->eh_ops.reset(ud); ud->eh_ops.reset(ud);
ud->event &= ~USBIP_EH_RESET; ud->event &= ~USBIP_EH_RESET;
break;
} }
/* Mark the device as unusable. */ /* Mark the device as unusable. */
@ -60,13 +52,11 @@ static int event_handler(struct usbip_device *ud)
ud->eh_ops.unusable(ud); ud->eh_ops.unusable(ud);
ud->event &= ~USBIP_EH_UNUSABLE; ud->event &= ~USBIP_EH_UNUSABLE;
break;
} }
/* NOTREACHED */ /* Stop the error handler. */
printk(KERN_ERR "%s: unknown event\n", __func__); if (ud->event & USBIP_EH_BYE)
return -1; return -1;
} }
return 0; return 0;