Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-22 20:22:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

i2c: amd-mp2-plat: use 'time_left' variable with wait_for_completion_timeout()

Browse Source 
There is a confusing pattern in the kernel to use a variable named 'timeout' to
store the result of wait_for_completion_timeout() causing patterns like:

	timeout = wait_for_completion_timeout(...)
	if (!timeout) return -ETIMEDOUT;

with all kinds of permutations. Use 'time_left' as a variable to make the code
self explaining.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: Andi Shyti <andi.shyti@kernel.org>
This commit is contained in:
Wolfram Sang 2024-04-27 22:35:53 +02:00 committed by Andi Shyti
parent 5895a867bb
commit 571b90f5d4
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/i2c/busses/i2c-amd-mp2-plat.c
View File

@ -97,17 +97,17 @@ static void i2c_amd_cmd_completion(struct amd_i2c_common *i2c_common)
static int i2c_amd_check_cmd_completion(struct amd_i2c_dev *i2c_dev) static int i2c_amd_check_cmd_completion(struct amd_i2c_dev *i2c_dev)
{ {
struct amd_i2c_common *i2c_common = &i2c_dev->common; struct amd_i2c_common *i2c_common = &i2c_dev->common;
unsigned long timeout; unsigned long time_left;
timeout = wait_for_completion_timeout(&i2c_dev->cmd_complete, time_left = wait_for_completion_timeout(&i2c_dev->cmd_complete,
i2c_dev->adap.timeout); i2c_dev->adap.timeout);
if ((i2c_common->reqcmd == i2c_read || if ((i2c_common->reqcmd == i2c_read ||
i2c_common->reqcmd == i2c_write) && i2c_common->reqcmd == i2c_write) &&
i2c_common->msg->len > 32) i2c_common->msg->len > 32)
i2c_amd_dma_unmap(i2c_common); i2c_amd_dma_unmap(i2c_common);
if (timeout == 0) { if (time_left == 0) {
amd_mp2_rw_timeout(i2c_common); amd_mp2_rw_timeout(i2c_common);
return -ETIMEDOUT; return -ETIMEDOUT;
} }