Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-26 14:12:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

pstore/platform: Switch pstore_info::name to const

Browse Source 
In order to more cleanly pass around backend names, make the "name" member
const. This means the module param needs to be dynamic (technically, it
was before, so this actually cleans up a minor memory leak if a backend
was specified and then gets unloaded.)

Link: https://lore.kernel.org/lkml/20200510202436.63222-3-keescook@chromium.org/
Signed-off-by: Kees Cook <keescook@chromium.org>
This commit is contained in:
Kees Cook 2020-05-08 09:16:02 -07:00
parent b7753fc7f6
commit 563ca40ddf
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
fs/pstore/platform.c
View File

@ -624,7 +624,7 @@ int pstore_register(struct pstore_info *psi)
* Update the module parameter backend, so it is visible * Update the module parameter backend, so it is visible
* through /sys/module/pstore/parameters/backend * through /sys/module/pstore/parameters/backend
*/ */
backend = psi->name; backend = kstrdup(psi->name, GFP_KERNEL);
pr_info("Registered %s as persistent store backend\n", psi->name); pr_info("Registered %s as persistent store backend\n", psi->name);
@ -667,6 +667,7 @@ void pstore_unregister(struct pstore_info *psi)
free_buf_for_compression(); free_buf_for_compression();
psinfo = NULL; psinfo = NULL;
kfree(backend);
backend = NULL; backend = NULL;
mutex_unlock(&psinfo_lock); mutex_unlock(&psinfo_lock);
} }

2
include/linux/pstore.h
View File

@ -170,7 +170,7 @@ struct pstore_record {
*/ */
struct pstore_info { struct pstore_info {
struct module *owner; struct module *owner;
char *name; const char *name;
struct semaphore buf_lock; struct semaphore buf_lock;
char *buf; char *buf;