mirror of
https://github.com/torvalds/linux.git
synced 2024-12-25 12:21:37 +00:00
hostap: convert hostap_cmd_queue.usecnt from atomic_t to refcount_t
refcount_t type and corresponding API should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to use-after-free situations. Signed-off-by: Elena Reshetova <elena.reshetova@intel.com> Signed-off-by: Hans Liljestrand <ishkamiel@gmail.com> Signed-off-by: Kees Cook <keescook@chromium.org> Signed-off-by: David Windsor <dwindsor@gmail.com> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
This commit is contained in:
parent
9029679f66
commit
552aa585fa
@ -190,7 +190,7 @@ static inline void __hostap_cmd_queue_free(local_info_t *local,
|
||||
}
|
||||
}
|
||||
|
||||
if (atomic_dec_and_test(&entry->usecnt) && entry->del_req)
|
||||
if (refcount_dec_and_test(&entry->usecnt) && entry->del_req)
|
||||
kfree(entry);
|
||||
}
|
||||
|
||||
@ -228,7 +228,7 @@ static void prism2_clear_cmd_queue(local_info_t *local)
|
||||
spin_lock_irqsave(&local->cmdlock, flags);
|
||||
list_for_each_safe(ptr, n, &local->cmd_queue) {
|
||||
entry = list_entry(ptr, struct hostap_cmd_queue, list);
|
||||
atomic_inc(&entry->usecnt);
|
||||
refcount_inc(&entry->usecnt);
|
||||
printk(KERN_DEBUG "%s: removed pending cmd_queue entry "
|
||||
"(type=%d, cmd=0x%04x, param0=0x%04x)\n",
|
||||
local->dev->name, entry->type, entry->cmd,
|
||||
@ -350,7 +350,7 @@ static int hfa384x_cmd(struct net_device *dev, u16 cmd, u16 param0,
|
||||
if (entry == NULL)
|
||||
return -ENOMEM;
|
||||
|
||||
atomic_set(&entry->usecnt, 1);
|
||||
refcount_set(&entry->usecnt, 1);
|
||||
entry->type = CMD_SLEEP;
|
||||
entry->cmd = cmd;
|
||||
entry->param0 = param0;
|
||||
@ -516,7 +516,7 @@ static int hfa384x_cmd_callback(struct net_device *dev, u16 cmd, u16 param0,
|
||||
if (entry == NULL)
|
||||
return -ENOMEM;
|
||||
|
||||
atomic_set(&entry->usecnt, 1);
|
||||
refcount_set(&entry->usecnt, 1);
|
||||
entry->type = CMD_CALLBACK;
|
||||
entry->cmd = cmd;
|
||||
entry->param0 = param0;
|
||||
@ -666,7 +666,7 @@ static void prism2_cmd_ev(struct net_device *dev)
|
||||
if (!list_empty(&local->cmd_queue)) {
|
||||
entry = list_entry(local->cmd_queue.next,
|
||||
struct hostap_cmd_queue, list);
|
||||
atomic_inc(&entry->usecnt);
|
||||
refcount_inc(&entry->usecnt);
|
||||
list_del_init(&entry->list);
|
||||
local->cmd_queue_len--;
|
||||
|
||||
@ -718,7 +718,7 @@ static void prism2_cmd_ev(struct net_device *dev)
|
||||
entry = NULL;
|
||||
}
|
||||
if (entry)
|
||||
atomic_inc(&entry->usecnt);
|
||||
refcount_inc(&entry->usecnt);
|
||||
}
|
||||
spin_unlock(&local->cmdlock);
|
||||
|
||||
|
@ -6,6 +6,7 @@
|
||||
#include <linux/netdevice.h>
|
||||
#include <linux/etherdevice.h>
|
||||
#include <linux/mutex.h>
|
||||
#include <linux/refcount.h>
|
||||
#include <net/iw_handler.h>
|
||||
#include <net/ieee80211_radiotap.h>
|
||||
#include <net/lib80211.h>
|
||||
@ -557,7 +558,7 @@ struct hostap_cmd_queue {
|
||||
u16 resp0, res;
|
||||
volatile int issued, issuing;
|
||||
|
||||
atomic_t usecnt;
|
||||
refcount_t usecnt;
|
||||
int del_req;
|
||||
};
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user