Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-21 19:41:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

firewire: ohci: add tracepoints event for data of Self-ID DMA

Browse Source 
In 1394 OHCI, the SelfIDComplete event occurs when the hardware has
finished transmitting all of the self ID packets received during the bus
initialization process to the host memory by DMA.

This commit adds a tracepoints event for this event to trace the timing
and packet data of Self-ID DMA. It is the part of following tracepoints
events helpful to debug some events at bus reset; e.g. the issue addressed
at a commit d0b06dc48f ("firewire: core: use long bus reset on gap count
error")[1]:

* firewire_ohci:irqs
* firewire_ohci:self_id_complete
* firewire:bus_reset_handle
* firewire:self_id_sequence

They would be also helpful in the problem about invocation timing of
hardIRQ and process (workqueue) contexts. We can often see this kind of
problem with -rt kernel[2].

[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=d0b06dc48fb1
[2] https://lore.kernel.org/linux-rt-users/YAwPoaUZ1gTD5y+k@hmbx/

Link: https://lore.kernel.org/r/20240702222034.1378764-6-o-takashi@sakamocchi.jp
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
This commit is contained in:
Takashi Sakamoto 2024-07-03 07:20:34 +09:00
parent 4a13617ef3
commit 526e21a2aa
2 changed files with 64 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
drivers/firewire/ohci.c
View File

@ -45,6 +45,8 @@
#include <trace/events/firewire.h>
static u32 cond_le32_to_cpu(__le32 value, bool has_be_header_quirk);
#define CREATE_TRACE_POINTS
#include <trace/events/firewire_ohci.h>
@ -2208,8 +2210,15 @@ static irqreturn_t irq_handler(int irq, void *data)
if (event & OHCI1394_busReset)
reg_write(ohci, OHCI1394_IntMaskClear, OHCI1394_busReset);
if (event & OHCI1394_selfIDComplete)
if (event & OHCI1394_selfIDComplete) {
if (trace_self_id_complete_enabled()) {
u32 reg = reg_read(ohci, OHCI1394_SelfIDCount);
trace_self_id_complete(ohci->card.index, reg, ohci->self_id,
has_be_header_quirk(ohci));
}
queue_work(selfid_workqueue, &ohci->bus_reset_work);
}
if (event & OHCI1394_RQPkt)
tasklet_schedule(&ohci->ar_request_ctx.tasklet);

54
include/trace/events/firewire_ohci.h
View File

@ -9,6 +9,8 @@
#include <linux/tracepoint.h>
// Some macros and helper functions are defined in 'drivers/firewire/ohci.c'.
TRACE_EVENT(irqs,
TP_PROTO(unsigned int card_index, u32 events),
TP_ARGS(card_index, events),
@ -42,6 +44,58 @@ TRACE_EVENT(irqs,
)
);
#define QUADLET_SIZE 4
#define SELF_ID_COUNT_IS_ERROR(reg) \
(!!(((reg) & OHCI1394_SelfIDCount_selfIDError_MASK) >> OHCI1394_SelfIDCount_selfIDError_SHIFT))
#define SELF_ID_COUNT_GET_GENERATION(reg) \
(((reg) & OHCI1394_SelfIDCount_selfIDGeneration_MASK) >> OHCI1394_SelfIDCount_selfIDGeneration_SHIFT)
#define SELF_ID_RECEIVE_Q0_GET_GENERATION(quadlet) \
(((quadlet) & OHCI1394_SELF_ID_RECEIVE_Q0_GENERATION_MASK) >> OHCI1394_SELF_ID_RECEIVE_Q0_GENERATION_SHIFT)
#define SELF_ID_RECEIVE_Q0_GET_TIMESTAMP(quadlet) \
(((quadlet) & OHCI1394_SELF_ID_RECEIVE_Q0_TIMESTAMP_MASK) >> OHCI1394_SELF_ID_RECEIVE_Q0_TIMESTAMP_SHIFT)
TRACE_EVENT(self_id_complete,
TP_PROTO(unsigned int card_index, u32 reg, const __le32 *self_id_receive, bool has_be_header_quirk),
TP_ARGS(card_index, reg, self_id_receive, has_be_header_quirk),
TP_STRUCT__entry(
__field(u8, card_index)
__field(u32, reg)
__dynamic_array(u32, self_id_receive, ohci1394_self_id_count_get_size(reg))
),
TP_fast_assign(
__entry->card_index = card_index;
__entry->reg = reg;
{
u32 *ptr = __get_dynamic_array(self_id_receive);
int i;
for (i = 0; i < __get_dynamic_array_len(self_id_receive) / QUADLET_SIZE; ++i)
ptr[i] = cond_le32_to_cpu(self_id_receive[i], has_be_header_quirk);
}
),
TP_printk(
"card_index=%u is_error=%s generation_at_bus_reset=%u generation_at_completion=%u timestamp=0x%04x packet_data=%s",
__entry->card_index,
SELF_ID_COUNT_IS_ERROR(__entry->reg) ? "true" : "false",
SELF_ID_COUNT_GET_GENERATION(__entry->reg),
SELF_ID_RECEIVE_Q0_GET_GENERATION(((const u32 *)__get_dynamic_array(self_id_receive))[0]),
SELF_ID_RECEIVE_Q0_GET_TIMESTAMP(((const u32 *)__get_dynamic_array(self_id_receive))[0]),
__print_array(((const u32 *)__get_dynamic_array(self_id_receive)) + 1,
(__get_dynamic_array_len(self_id_receive) / QUADLET_SIZE) - 1, QUADLET_SIZE)
)
);
#undef SELF_ID_COUNT_IS_ERROR
#undef SELF_ID_COUNT_GET_GENERATION
#undef SELF_ID_RECEIVE_Q0_GET_GENERATION
#undef SELF_ID_RECEIVE_Q0_GET_TIMESTAMP
#undef QUADLET_SIZE
#endif // _FIREWIRE_OHCI_TRACE_EVENT_H
#include <trace/define_trace.h>