Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-28 15:11:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

mtd: fix memory leaks in phram_setup

Browse Source 
There are two code paths in drivers/mtd/devices/phram.c::phram_setup() that
will leak memory.
Memory is allocated to the variable 'name' with kmalloc() by the
parse_name() function, but if we leave by way of the parse_err() macro,
then that memory is never kfree()'d, nor is it ever used with
register_device() so it won't be freed later either - leak.

Found by the Coverity checker as #593 - simple fix below.

Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
Signed-off-by: David Woodhouse <dwmw2@infradead.org>
This commit is contained in:
Jesper Juhl 2006-05-14 01:07:18 +02:00 committed by David Woodhouse
parent e0c7d76753
commit 4f678a58d3
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/mtd/devices/phram.c
View File

@ -266,12 +266,16 @@ static int phram_setup(const char *val, struct kernel_param *kp)
return 0; return 0;
ret = parse_num32(&start, token[1]); ret = parse_num32(&start, token[1]);
if (ret) if (ret) {
kfree(name);
parse_err("illegal start address\n"); parse_err("illegal start address\n");
}
ret = parse_num32(&len, token[2]); ret = parse_num32(&len, token[2]);
if (ret) if (ret) {
kfree(name);
parse_err("illegal device length\n"); parse_err("illegal device length\n");
}
register_device(name, start, len); register_device(name, start, len);