Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-12-11 21:52:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

[S390] vmur: add "top of queue" sanity check for reader open

Browse Source 
If the z/VM reader is already open, it can happen that after opening the
Linux reader device, not the topmost file is processed. According the
semantics of the Linux z/VM unit record device driver, always the topmost
file has to be processed. With this fix an error is returned if that is
not the case.

Signed-off-by: Michael Holzheu <holzheu@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
This commit is contained in:
Michael Holzheu 2007-08-10 14:32:33 +02:00 committed by Martin Schwidefsky
parent f2405598e0
commit 4eac34529b
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/s390/char/vmur.c
View File

@ -565,9 +565,14 @@ static int verify_device(struct urdev *urd)
return -ENOMEM;
rc = diag_read_file(urd->dev_id.devno, buf);
kfree(buf);
if ((rc != 0) && (rc != -ENODATA)) /* EOF does not hurt */
return rc;
/* check if the file on top of the queue is open now */
rc = diag_read_next_file_info(&fcb, 0);
if (rc)
return rc;
if (!(fcb.file_stat & FLG_IN_USE))
return -EMFILE;
return 0;
default:
return -ENOTSUPP;

1
drivers/s390/char/vmur.h
View File

@ -53,6 +53,7 @@ struct file_control_block {
#define FLG_SYSTEM_HOLD 0x04
#define FLG_CP_DUMP 0x10
#define FLG_USER_HOLD 0x20
#define FLG_IN_USE 0x80
/*
* A struct urdev is created for each ur device that is made available