Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-23 20:51:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

sysfs: Fix return values for sysdev_store_{ulong,int}

Browse Source 
SYSFS: Fix return values for sysdev_store_{ulong,int}

Always return the full size instead of the consumed
length of the string in sysdev_store_{ulong,int}

This avoids EINVAL errors in some echo versions.

Signed-off-by: Andi Kleen <ak@linux.intel.com>
Cc: stable <stable@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Andi Kleen 2008-10-13 12:03:03 +02:00 committed by Greg Kroah-Hartman
parent 65151365ad
commit 4e318d7c6c
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/base/sys.c
View File

@ -488,7 +488,8 @@ ssize_t sysdev_store_ulong(struct sys_device *sysdev,
if (end == buf) if (end == buf)
return -EINVAL; return -EINVAL;
*(unsigned long *)(ea->var) = new; *(unsigned long *)(ea->var) = new;
return end - buf; /* Always return full write size even if we didn't consume all */
return size;
} }
EXPORT_SYMBOL_GPL(sysdev_store_ulong); EXPORT_SYMBOL_GPL(sysdev_store_ulong);
@ -511,7 +512,8 @@ ssize_t sysdev_store_int(struct sys_device *sysdev,
if (end == buf || new > INT_MAX || new < INT_MIN) if (end == buf || new > INT_MAX || new < INT_MIN)
return -EINVAL; return -EINVAL;
*(int *)(ea->var) = new; *(int *)(ea->var) = new;
return end - buf; /* Always return full write size even if we didn't consume all */
return size;
} }
EXPORT_SYMBOL_GPL(sysdev_store_int); EXPORT_SYMBOL_GPL(sysdev_store_int);