Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-10-24 14:10:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

media: i2c: Fix pm_runtime_get_if_in_use() usage in sensor drivers

Browse Source 
pm_runtime_get_if_in_use() returns -EINVAL if runtime PM is disabled. This
should not be considered an error. Generally the driver has enabled
runtime PM already so getting this error due to runtime PM being disabled
will not happen.

Instead of checking for lesser or equal to zero, check for zero only.
Address this for drivers where this pattern exists.

This patch has been produced using the following command:

$ git grep -l pm_runtime_get_if_in_use -- drivers/media/i2c/ | \
  xargs perl -i -pe 's/(pm_runtime_get_if_in_use\(.*\)) \<\= 0/!$1/'

Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Reviewed-by: Tomasz Figa <tfiga@chromium.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
This commit is contained in:
Sakari Ailus 2018-07-30 07:44:43 -04:00 committed by Mauro Carvalho Chehab
parent d508fffb92
commit 4d471563d8
5 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/media/i2c/ov13858.c
View File

@ -1230,7 +1230,7 @@ static int ov13858_set_ctrl(struct v4l2_ctrl *ctrl)
* Applying V4L2 control value only happens
* when power is up for streaming
*/
if (pm_runtime_get_if_in_use(&client->dev) <= 0)
if (!pm_runtime_get_if_in_use(&client->dev))
return 0;
ret = 0;

2
drivers/media/i2c/ov2685.c
View File

@ -549,7 +549,7 @@ static int ov2685_set_ctrl(struct v4l2_ctrl *ctrl)
break;
}
if (pm_runtime_get_if_in_use(&client->dev) <= 0)
if (!pm_runtime_get_if_in_use(&client->dev))
return 0;
switch (ctrl->id) {

2
drivers/media/i2c/ov5670.c
View File

@ -2016,7 +2016,7 @@ static int ov5670_set_ctrl(struct v4l2_ctrl *ctrl)
}
/* V4L2 controls values will be applied only when power is already up */
if (pm_runtime_get_if_in_use(&client->dev) <= 0)
if (!pm_runtime_get_if_in_use(&client->dev))
return 0;
switch (ctrl->id) {

2
drivers/media/i2c/ov5695.c
View File

@ -1110,7 +1110,7 @@ static int ov5695_set_ctrl(struct v4l2_ctrl *ctrl)
break;
}
if (pm_runtime_get_if_in_use(&client->dev) <= 0)
if (!pm_runtime_get_if_in_use(&client->dev))
return 0;
switch (ctrl->id) {

2
drivers/media/i2c/ov7740.c
View File

@ -510,7 +510,7 @@ static int ov7740_set_ctrl(struct v4l2_ctrl *ctrl)
int ret;
u8 val = 0;
if (pm_runtime_get_if_in_use(&client->dev) <= 0)
if (!pm_runtime_get_if_in_use(&client->dev))
return 0;
switch (ctrl->id) {