Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-12-04 18:13:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

staging: speakup: Clean up tests if NULL returned on failure

Browse Source 
Some functions like kmalloc/kzalloc return NULL on failure.
When NULL represents failure, !x is commonly used.

This was done using Coccinelle:
@@
expression *e;
identifier l1;
@@

e = \(kmalloc\|kzalloc\|kcalloc\|devm_kzalloc\)(...);
...
- e == NULL
+ !e

Signed-off-by: simran singhal <singhalsimran0@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
simran singhal 2017-03-04 22:16:54 +05:30 committed by Greg Kroah-Hartman
parent 1839f03706
commit 4be4c37929
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/staging/speakup/main.c
View File

@ -1324,7 +1324,7 @@ static int speakup_allocate(struct vc_data *vc)
if (speakup_console[vc_num] == NULL) { if (speakup_console[vc_num] == NULL) {
speakup_console[vc_num] = kzalloc(sizeof(*speakup_console[0]), speakup_console[vc_num] = kzalloc(sizeof(*speakup_console[0]),
GFP_ATOMIC); GFP_ATOMIC);
if (speakup_console[vc_num] == NULL) if (!speakup_console[vc_num])
return -ENOMEM; return -ENOMEM;
speakup_date(vc); speakup_date(vc);
} else if (!spk_parked) } else if (!spk_parked)