Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-21 19:41:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

proc: fold kmalloc() + strcpy() into kmemdup()

Browse Source 
strcpy() will recalculate string length second time which is
unnecessary in this case.

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Link: https://lore.kernel.org/r/90af27c1-0b86-47a6-a6c8-61a58b8aa747@p183
Signed-off-by: Christian Brauner <brauner@kernel.org>
This commit is contained in:
Alexey Dobriyan 2024-09-08 12:27:45 +03:00 committed by Christian Brauner
parent d80b065bb1
commit 4ad5f9a021
No known key found for this signature in database
GPG Key ID: 91C61BC06578DCA2
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
fs/proc/generic.c
View File

@ -464,9 +464,9 @@ struct proc_dir_entry *proc_symlink(const char *name,
(S_IFLNK | S_IRUGO | S_IWUGO | S_IXUGO),1); (S_IFLNK | S_IRUGO | S_IWUGO | S_IXUGO),1);
if (ent) { if (ent) {
ent->data = kmalloc((ent->size=strlen(dest))+1, GFP_KERNEL); ent->size = strlen(dest);
ent->data = kmemdup(dest, ent->size + 1, GFP_KERNEL);
if (ent->data) { if (ent->data) {
strcpy((char*)ent->data,dest);
ent->proc_iops = &proc_link_inode_operations; ent->proc_iops = &proc_link_inode_operations;
ent = proc_register(parent, ent); ent = proc_register(parent, ent);
} else { } else {