Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-12-22 10:56:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

wl1271: remove workaround to ignore -EIO from radio and general params

Browse Source 
We were ignoring the -EIO return value from wl1271_cmd_radio_params() and
wl1271_cmd_general_params(), because they were always returning an error and
we didn't know why.  Now this has been fixed, so the workaround can be
removed.

Signed-off-by: Luciano Coelho <luciano.coelho@nokia.com>
Reviewed-by: Juuso Oikarinen <juuso.oikarinen@nokia.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
This commit is contained in:
Luciano Coelho 2009-11-23 23:22:18 +02:00 committed by John W. Linville
parent 98b5dd5ded
commit 4a90406b87
2 changed files with 4 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/net/wireless/wl12xx/wl1271_init.c
View File

@ -197,15 +197,12 @@ int wl1271_hw_init(struct wl1271 *wl)
{
int ret;
/* FIXME: the following parameter setting functions return error
* codes - the reason is so far unknown. The -EIO is therefore
* ignored for the time being. */
ret = wl1271_cmd_general_parms(wl);
if (ret < 0 && ret != -EIO)
if (ret < 0)
return ret;
ret = wl1271_cmd_radio_parms(wl);
if (ret < 0 && ret != -EIO)
if (ret < 0)
return ret;
/* Template settings */

7
drivers/net/wireless/wl12xx/wl1271_main.c
View File

@ -354,15 +354,12 @@ static int wl1271_plt_init(struct wl1271 *wl)
{
int ret;
/* FIXME: the following parameter setting functions return error
* codes - the reason is so far unknown. The -EIO is therefore
* ignored for the time being. */
ret = wl1271_cmd_general_parms(wl);
if (ret < 0 && ret != -EIO)
if (ret < 0)
return ret;
ret = wl1271_cmd_radio_parms(wl);
if (ret < 0 && ret != -EIO)
if (ret < 0)
return ret;
ret = wl1271_acx_init_mem_config(wl);