Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-21 19:41:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revert "vfs: Delete the associated dentry when deleting a file"

Browse Source 
This reverts commit 681ce86235.

We gave it a try, but it turns out the kernel test robot did in fact
find performance regressions for it, so we'll have to look at the more
involved alternative fixes for Yafang Shao's Elasticsearch load issue.

There were several alternatives discussed, they just weren't as simple
as this first attempt.

The report is of a -7.4% regression of filebench.sum_operations/s, which
appears significant enough to trigger my "this patch may get reverted if
somebody finds a performance regression on some other load" rule.

So it's still the case that we should end up deleting dentries more
aggressively - or just be better at pruning them later - but it needs a
bit more finesse than this simple thing.

Link: https://lore.kernel.org/all/202405291318.4dfbb352-oliver.sang@intel.com/
Cc: Yafang Shao <laoar.shao@gmail.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Christian Brauner <brauner@kernel.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Linus Torvalds 2024-05-29 09:39:34 -07:00
parent 397a83ab97
commit 4a4be1ad3a
1 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
fs/dcache.c
View File

@ -2360,17 +2360,19 @@ EXPORT_SYMBOL(d_hash_and_lookup);
* - unhash this dentry and free it. * - unhash this dentry and free it.
* *
* Usually, we want to just turn this into * Usually, we want to just turn this into
* a negative dentry, but certain workloads can * a negative dentry, but if anybody else is
* generate a large number of negative dentries. * currently using the dentry or the inode
* Therefore, it would be better to simply * we can't do that and we fall back on removing
* unhash it. * it from the hash queues and waiting for
* it to be deleted later when it has no users
*/ */
/** /**
* d_delete - delete a dentry * d_delete - delete a dentry
* @dentry: The dentry to delete * @dentry: The dentry to delete
* *
* Remove the dentry from the hash queues so it can be deleted later. * Turn the dentry into a negative dentry if possible, otherwise
* remove it from the hash queues so it can be deleted later
*/ */
void d_delete(struct dentry * dentry) void d_delete(struct dentry * dentry)
@ -2379,8 +2381,6 @@ void d_delete(struct dentry * dentry)
spin_lock(&inode->i_lock); spin_lock(&inode->i_lock);
spin_lock(&dentry->d_lock); spin_lock(&dentry->d_lock);
__d_drop(dentry);
/* /*
* Are we the only user? * Are we the only user?
*/ */
@ -2388,6 +2388,7 @@ void d_delete(struct dentry * dentry)
dentry->d_flags &= ~DCACHE_CANT_MOUNT; dentry->d_flags &= ~DCACHE_CANT_MOUNT;
dentry_unlink_inode(dentry); dentry_unlink_inode(dentry);
} else { } else {
__d_drop(dentry);
spin_unlock(&dentry->d_lock); spin_unlock(&dentry->d_lock);
spin_unlock(&inode->i_lock); spin_unlock(&inode->i_lock);
} }