Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-24 21:21:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

page_pool: fix compile warning when CONFIG_PAGE_POOL is disabled

Browse Source 
Kbuild test robot reported compile warning:
 warning: no return statement in function returning non-void
in function page_pool_request_shutdown, when CONFIG_PAGE_POOL is disabled.

The fix makes the code a little more verbose, with a descriptive variable.

Fixes: 99c07c43c4 ("xdp: tracking page_pool resources and safe removal")
Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Jesper Dangaard Brouer 2019-06-20 00:15:52 +02:00 committed by David S. Miller
parent 84ce4d0f9f
commit 497ad9f5b2
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
include/net/page_pool.h
View File

@ -156,12 +156,12 @@ static inline void page_pool_recycle_direct(struct page_pool *pool,
bool __page_pool_request_shutdown(struct page_pool *pool);
static inline bool page_pool_request_shutdown(struct page_pool *pool)
{
/* When page_pool isn't compiled-in, net/core/xdp.c doesn't
* allow registering MEM_TYPE_PAGE_POOL, but shield linker.
*/
bool safe_to_remove = false;
#ifdef CONFIG_PAGE_POOL
return __page_pool_request_shutdown(pool);
safe_to_remove = __page_pool_request_shutdown(pool);
#endif
return safe_to_remove;
}
/* Disconnects a page (from a page_pool). API users can have a need