Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-12-12 06:02:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

x86/fpu: Use XFEATURE_FP/SSE enum values instead of hardcoded numbers

Browse Source 
When setting up sizes and offsets for legacy header entries the code uses
hardcoded 0/1 instead of the corresponding enum values XFEATURE_FP and
XFEATURE_SSE.

Replace the hardcoded numbers which enhances readability of the code and
also makes this code the first user of those enum values..

Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lkml.kernel.org/r/20191101130153.GG1615@uranus.lan
This commit is contained in:
Cyrill Gorcunov 2019-11-01 16:01:53 +03:00 committed by Thomas Gleixner
parent c08550510c
commit 446e693ca3
1 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
arch/x86/kernel/fpu/xstate.c
View File

@ -254,10 +254,13 @@ static void __init setup_xstate_features(void)
* in the fixed offsets in the xsave area in either compacted form * in the fixed offsets in the xsave area in either compacted form
* or standard form. * or standard form.
*/ */
xstate_offsets[0] = 0; xstate_offsets[XFEATURE_FP] = 0;
xstate_sizes[0] = offsetof(struct fxregs_state, xmm_space); xstate_sizes[XFEATURE_FP] = offsetof(struct fxregs_state,
xstate_offsets[1] = xstate_sizes[0]; xmm_space);
xstate_sizes[1] = FIELD_SIZEOF(struct fxregs_state, xmm_space);
xstate_offsets[XFEATURE_SSE] = xstate_sizes[XFEATURE_FP];
xstate_sizes[XFEATURE_SSE] = FIELD_SIZEOF(struct fxregs_state,
xmm_space);
for (i = FIRST_EXTENDED_XFEATURE; i < XFEATURE_MAX; i++) { for (i = FIRST_EXTENDED_XFEATURE; i < XFEATURE_MAX; i++) {
if (!xfeature_enabled(i)) if (!xfeature_enabled(i))
@ -350,8 +353,9 @@ static void __init setup_xstate_comp(void)
* in the fixed offsets in the xsave area in either compacted form * in the fixed offsets in the xsave area in either compacted form
* or standard form. * or standard form.
*/ */
xstate_comp_offsets[0] = 0; xstate_comp_offsets[XFEATURE_FP] = 0;
xstate_comp_offsets[1] = offsetof(struct fxregs_state, xmm_space); xstate_comp_offsets[XFEATURE_SSE] = offsetof(struct fxregs_state,
xmm_space);
if (!boot_cpu_has(X86_FEATURE_XSAVES)) { if (!boot_cpu_has(X86_FEATURE_XSAVES)) {
for (i = FIRST_EXTENDED_XFEATURE; i < XFEATURE_MAX; i++) { for (i = FIRST_EXTENDED_XFEATURE; i < XFEATURE_MAX; i++) {