Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-24 13:11:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

ipv6: fix incorrect bitwise operator used on rt6i_flags

Browse Source 
The use of the | operator always leads to true which looks rather
suspect to me. Fix this by using & instead to just check the
RTF_CACHE entry bit.

Detected by CoverityScan, CID#1457734, #1457747 ("Wrong operator used")

Fixes: 35732d01fe ("ipv6: introduce a hash table to store dst cache")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Wei Wang <weiwan@google.com>
Acked-by: Martin KaFai Lau <kafai@fb.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Colin Ian King 2017-10-10 19:10:30 +01:00 committed by David S. Miller
parent b2427e6717
commit 442d713baa
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
net/ipv6/route.c
View File

@ -1415,7 +1415,7 @@ int rt6_remove_exception_rt(struct rt6_info *rt)
int err;
if (!from ||
!(rt->rt6i_flags | RTF_CACHE))
!(rt->rt6i_flags & RTF_CACHE))
return -EINVAL;
if (!rcu_access_pointer(from->rt6i_exception_bucket))
@ -1459,7 +1459,7 @@ static void rt6_update_exception_stamp_rt(struct rt6_info *rt)
struct rt6_exception *rt6_ex;
if (!from ||
!(rt->rt6i_flags | RTF_CACHE))
!(rt->rt6i_flags & RTF_CACHE))
return;
rcu_read_lock();