mirror of
https://github.com/torvalds/linux.git
synced 2024-11-22 20:22:09 +00:00
V4L/DVB (7905): check_v4l2 should return -EINVAL on error
check_v4l2 always returns 0, so this change is an noop for now, but a comment says it will return something else in the future Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
This commit is contained in:
parent
4d3437df25
commit
427aad6fda
@ -792,7 +792,7 @@ static int tuner_command(struct i2c_client *client, unsigned int cmd, void *arg)
|
||||
case VIDIOCSAUDIO:
|
||||
if (check_mode(t, "VIDIOCSAUDIO") == -EINVAL)
|
||||
return 0;
|
||||
if (check_v4l2(t) == EINVAL)
|
||||
if (check_v4l2(t) == -EINVAL)
|
||||
return 0;
|
||||
|
||||
/* Should be implemented, since bttv calls it */
|
||||
@ -810,7 +810,7 @@ static int tuner_command(struct i2c_client *client, unsigned int cmd, void *arg)
|
||||
};
|
||||
struct video_channel *vc = arg;
|
||||
|
||||
if (check_v4l2(t) == EINVAL)
|
||||
if (check_v4l2(t) == -EINVAL)
|
||||
return 0;
|
||||
|
||||
if (set_mode(client,t,V4L2_TUNER_ANALOG_TV, "VIDIOCSCHAN")==-EINVAL)
|
||||
@ -829,7 +829,7 @@ static int tuner_command(struct i2c_client *client, unsigned int cmd, void *arg)
|
||||
|
||||
if (check_mode(t, "VIDIOCSFREQ") == -EINVAL)
|
||||
return 0;
|
||||
if (check_v4l2(t) == EINVAL)
|
||||
if (check_v4l2(t) == -EINVAL)
|
||||
return 0;
|
||||
|
||||
set_freq(client, *v);
|
||||
@ -841,7 +841,7 @@ static int tuner_command(struct i2c_client *client, unsigned int cmd, void *arg)
|
||||
|
||||
if (check_mode(t, "VIDIOCGTUNER") == -EINVAL)
|
||||
return 0;
|
||||
if (check_v4l2(t) == EINVAL)
|
||||
if (check_v4l2(t) == -EINVAL)
|
||||
return 0;
|
||||
|
||||
if (V4L2_TUNER_RADIO == t->mode) {
|
||||
@ -885,7 +885,7 @@ static int tuner_command(struct i2c_client *client, unsigned int cmd, void *arg)
|
||||
|
||||
if (check_mode(t, "VIDIOCGAUDIO") == -EINVAL)
|
||||
return 0;
|
||||
if (check_v4l2(t) == EINVAL)
|
||||
if (check_v4l2(t) == -EINVAL)
|
||||
return 0;
|
||||
|
||||
if (V4L2_TUNER_RADIO == t->mode) {
|
||||
|
Loading…
Reference in New Issue
Block a user