Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-12-01 16:41:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

spi: mpc52xx: Convert to platform remove callback returning void

Browse Source 
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230303172041.2103336-41-u.kleine-koenig@pengutronix.de
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Uwe Kleine-König 2023-03-03 18:19:54 +01:00 committed by Mark Brown
parent beb6ed0f8c
commit 3fa689a85d
No known key found for this signature in database
GPG Key ID: 24D68B725D5487D0
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/spi/spi-mpc52xx.c
View File

@ -513,7 +513,7 @@ static int mpc52xx_spi_probe(struct platform_device *op)
return rc; return rc;
} }
static int mpc52xx_spi_remove(struct platform_device *op) static void mpc52xx_spi_remove(struct platform_device *op)
{ {
struct spi_master *master = spi_master_get(platform_get_drvdata(op)); struct spi_master *master = spi_master_get(platform_get_drvdata(op));
struct mpc52xx_spi *ms = spi_master_get_devdata(master); struct mpc52xx_spi *ms = spi_master_get_devdata(master);
@ -529,8 +529,6 @@ static int mpc52xx_spi_remove(struct platform_device *op)
spi_unregister_master(master); spi_unregister_master(master);
iounmap(ms->regs); iounmap(ms->regs);
spi_master_put(master); spi_master_put(master);
return 0;
} }
static const struct of_device_id mpc52xx_spi_match[] = { static const struct of_device_id mpc52xx_spi_match[] = {
@ -545,6 +543,6 @@ static struct platform_driver mpc52xx_spi_of_driver = {
.of_match_table = mpc52xx_spi_match, .of_match_table = mpc52xx_spi_match,
}, },
.probe = mpc52xx_spi_probe, .probe = mpc52xx_spi_probe,
.remove = mpc52xx_spi_remove, .remove_new = mpc52xx_spi_remove,
}; };
module_platform_driver(mpc52xx_spi_of_driver); module_platform_driver(mpc52xx_spi_of_driver);