mirror of
https://github.com/torvalds/linux.git
synced 2024-12-05 18:41:23 +00:00
usb: usbfs: use irqsave() in USB's complete callback
The USB completion callback does not disable interrupts while acquiring the lock. We want to remove the local_irq_disable() invocation from __usb_hcd_giveback_urb() and therefore it is required for the callback handler to disable the interrupts while acquiring the lock. The callback may be invoked either in IRQ or BH context depending on the USB host controller. Use the _irqsave() variant of the locking primitives. Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Acked-by: Alan Stern <stern@rowland.harvard.edu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
31adcb0a9c
commit
3f38dace1a
@ -585,9 +585,10 @@ static void async_completed(struct urb *urb)
|
|||||||
struct siginfo sinfo;
|
struct siginfo sinfo;
|
||||||
struct pid *pid = NULL;
|
struct pid *pid = NULL;
|
||||||
const struct cred *cred = NULL;
|
const struct cred *cred = NULL;
|
||||||
|
unsigned long flags;
|
||||||
int signr;
|
int signr;
|
||||||
|
|
||||||
spin_lock(&ps->lock);
|
spin_lock_irqsave(&ps->lock, flags);
|
||||||
list_move_tail(&as->asynclist, &ps->async_completed);
|
list_move_tail(&as->asynclist, &ps->async_completed);
|
||||||
as->status = urb->status;
|
as->status = urb->status;
|
||||||
signr = as->signr;
|
signr = as->signr;
|
||||||
@ -611,7 +612,7 @@ static void async_completed(struct urb *urb)
|
|||||||
cancel_bulk_urbs(ps, as->bulk_addr);
|
cancel_bulk_urbs(ps, as->bulk_addr);
|
||||||
|
|
||||||
wake_up(&ps->wait);
|
wake_up(&ps->wait);
|
||||||
spin_unlock(&ps->lock);
|
spin_unlock_irqrestore(&ps->lock, flags);
|
||||||
|
|
||||||
if (signr) {
|
if (signr) {
|
||||||
kill_pid_info_as_cred(sinfo.si_signo, &sinfo, pid, cred);
|
kill_pid_info_as_cred(sinfo.si_signo, &sinfo, pid, cred);
|
||||||
|
Loading…
Reference in New Issue
Block a user