Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-23 04:31:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

net/rds: Drop duplicate sin and sin6 assignments

Browse Source 
There is no need to assign the msg->msg_name to sin or sin6,
because there is DECLARE_SOCKADDR statement.

Signed-off-by: Yejune Deng <yejune.deng@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Yejune Deng 2021-03-10 11:23:43 +08:00 committed by David S. Miller
parent 4b18d5d1b2
commit 3e6f20e09a
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
net/rds/recv.c
View File

@ -722,8 +722,6 @@ int rds_recvmsg(struct socket *sock, struct msghdr *msg, size_t size,
if (msg->msg_name) { if (msg->msg_name) {
if (ipv6_addr_v4mapped(&inc->i_saddr)) { if (ipv6_addr_v4mapped(&inc->i_saddr)) {
sin = (struct sockaddr_in *)msg->msg_name;
sin->sin_family = AF_INET; sin->sin_family = AF_INET;
sin->sin_port = inc->i_hdr.h_sport; sin->sin_port = inc->i_hdr.h_sport;
sin->sin_addr.s_addr = sin->sin_addr.s_addr =
@ -731,8 +729,6 @@ int rds_recvmsg(struct socket *sock, struct msghdr *msg, size_t size,
memset(sin->sin_zero, 0, sizeof(sin->sin_zero)); memset(sin->sin_zero, 0, sizeof(sin->sin_zero));
msg->msg_namelen = sizeof(*sin); msg->msg_namelen = sizeof(*sin);
} else { } else {
sin6 = (struct sockaddr_in6 *)msg->msg_name;
sin6->sin6_family = AF_INET6; sin6->sin6_family = AF_INET6;
sin6->sin6_port = inc->i_hdr.h_sport; sin6->sin6_port = inc->i_hdr.h_sport;
sin6->sin6_addr = inc->i_saddr; sin6->sin6_addr = inc->i_saddr;