mirror of
https://github.com/torvalds/linux.git
synced 2024-12-14 07:02:23 +00:00
i2c: designware: Fix return value check in navi_amd_register_client()
In case of error, the function i2c_new_client_device() returns
ERR_PTR() and never returns NULL. The NULL test in the return
value check should be replaced with IS_ERR().
Fixes: 17631e8ca2
("i2c: designware: Add driver support for AMD NAVI GPU")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
This commit is contained in:
parent
010e32ab20
commit
3ab4ce2daf
@ -132,8 +132,8 @@ static int navi_amd_register_client(struct dw_i2c_dev *dev)
|
||||
info.irq = dev->irq;
|
||||
|
||||
dev->slave = i2c_new_client_device(&dev->adapter, &info);
|
||||
if (!dev->slave)
|
||||
return -ENODEV;
|
||||
if (IS_ERR(dev->slave))
|
||||
return PTR_ERR(dev->slave);
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
Loading…
Reference in New Issue
Block a user