Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-26 06:02:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

sysfs: prevent warning when only using binary attributes

Browse Source 
When only using bin_attrs instead of attrs the kernel prints a warning
and refuses to create the sysfs entry. This fixes that.

Signed-off-by: Oliver Schinagl <oliver@schinagl.nl>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Oliver Schinagl 2013-07-14 16:05:56 -07:00 committed by Greg Kroah-Hartman
parent 6ab9cea160
commit 388a8c353d
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
fs/sysfs/group.c
View File

@ -93,8 +93,8 @@ static int internal_create_group(struct kobject *kobj, int update,
/* Updates may happen before the object has been instantiated */ /* Updates may happen before the object has been instantiated */
if (unlikely(update && !kobj->sd)) if (unlikely(update && !kobj->sd))
return -EINVAL; return -EINVAL;
if (!grp->attrs) { if (!grp->attrs && !grp->bin_attrs) {
WARN(1, "sysfs: attrs not set by subsystem for group: %s/%s\n", WARN(1, "sysfs: (bin_)attrs not set by subsystem for group: %s/%s\n",
kobj->name, grp->name ? "" : grp->name); kobj->name, grp->name ? "" : grp->name);
return -EINVAL; return -EINVAL;
} }