Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-12-20 10:01:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

usb: gadget: at91_udc: don't use [delayed_]work_pending()

Browse Source 
There's no need to test whether a (delayed) work item in pending
before queueing, flushing or cancelling it.  Most uses are unnecessary
and quite a few of them are buggy.

Remove unnecessary pending tests from at91_udc.  Only compile tested.

Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Andrew Victor <linux@maxim.org.za>
Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
Cc: linux-usb@vger.kernel.org
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
This commit is contained in:
Tejun Heo 2012-12-21 17:57:12 -08:00 committed by Felipe Balbi
parent 32c9cf22fc
commit 348409a267
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/usb/gadget/at91_udc.c
View File

@ -1621,8 +1621,7 @@ static void at91_vbus_timer(unsigned long data)
* bus such as i2c or spi which may sleep, so schedule some work * bus such as i2c or spi which may sleep, so schedule some work
* to read the vbus gpio * to read the vbus gpio
*/ */
if (!work_pending(&udc->vbus_timer_work)) schedule_work(&udc->vbus_timer_work);
schedule_work(&udc->vbus_timer_work);
} }
static int at91_start(struct usb_gadget *gadget, static int at91_start(struct usb_gadget *gadget,