Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-23 12:42:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

staging: comedi: me4000: remove unnecessary me4000_ai_cancel()

Browse Source 
The comedi core ensures that the subdevice is not busy before it allows
starting a new command. The subdevice (*cancel) is called when the
subdevice is set to not busy. In this driver the me4000_ai_cancel()
is the ai (*cancel) so the extra call in the ai (*do_cmd) is not
necessary. Remove it.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
H Hartley Sweeten 2015-08-05 10:45:12 -07:00 committed by Greg Kroah-Hartman
parent 78e4a573bf
commit 2ff848c3be
1 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/staging/comedi/drivers/me4000.c
View File

@ -665,12 +665,6 @@ static int me4000_ai_do_cmd(struct comedi_device *dev,
struct me4000_private *devpriv = dev->private;
struct comedi_cmd *cmd = &s->async->cmd;
unsigned int ctrl;
int err;
/* Reset the analog input */
err = me4000_ai_cancel(dev, s);
if (err)
return err;
/* Write timer arguments */
outl(devpriv->ai_init_ticks - 1,