Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-12-23 19:31:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

USB: fix error handling for mct_u232

Browse Source 
we report errors to the caller. THis patch adds error handling to the driver.

Signed-off-by: Oliver Neukum <oneukum@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Oliver Neukum 2007-03-29 10:45:17 +02:00 committed by Greg Kroah-Hartman
parent 9306fff17d
commit 2f007de2f4
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/usb/serial/mct_u232.c
View File

@ -438,17 +438,21 @@ static int mct_u232_open (struct usb_serial_port *port, struct file *filp)
if (retval) { if (retval) {
err("usb_submit_urb(read bulk) failed pipe 0x%x err %d", err("usb_submit_urb(read bulk) failed pipe 0x%x err %d",
port->read_urb->pipe, retval); port->read_urb->pipe, retval);
goto exit; goto error;
} }
port->interrupt_in_urb->dev = port->serial->dev; port->interrupt_in_urb->dev = port->serial->dev;
retval = usb_submit_urb(port->interrupt_in_urb, GFP_KERNEL); retval = usb_submit_urb(port->interrupt_in_urb, GFP_KERNEL);
if (retval) if (retval) {
usb_kill_urb(port->read_urb);
err(" usb_submit_urb(read int) failed pipe 0x%x err %d", err(" usb_submit_urb(read int) failed pipe 0x%x err %d",
port->interrupt_in_urb->pipe, retval); port->interrupt_in_urb->pipe, retval);
goto error;
exit: }
return 0; return 0;
error:
return retval;
} /* mct_u232_open */ } /* mct_u232_open */