Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-12-27 13:22:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

mtd: gpmi-nand: make debug prints more clear

Browse Source 
Make the error messages more debugging friendly

Signed-off-by: Vikram Narayanan <vikram186@gmail.com>
Acked-by: Huang Shijie <b32955@freescale.com>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
This commit is contained in:
Vikram Narayanan 2012-09-23 15:18:32 +05:30 committed by Artem Bityutskiy
parent 438db5a92b
commit 2d350e5adb
1 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
drivers/mtd/nand/gpmi-nand/gpmi-nand.c
View File

@ -222,7 +222,7 @@ void prepare_data_dma(struct gpmi_nand_data *this, enum dma_data_direction dr)
ret = dma_map_sg(this->dev, sgl, 1, dr); ret = dma_map_sg(this->dev, sgl, 1, dr);
if (ret == 0) if (ret == 0)
pr_err("map failed.\n"); pr_err("DMA mapping failed.\n");
this->direct_dma_map_ok = false; this->direct_dma_map_ok = false;
} }
@ -456,7 +456,7 @@ static int __devinit acquire_dma_channels(struct gpmi_nand_data *this)
dma_chan = dma_request_channel(mask, gpmi_dma_filter, this); dma_chan = dma_request_channel(mask, gpmi_dma_filter, this);
if (!dma_chan) { if (!dma_chan) {
pr_err("dma_request_channel failed.\n"); pr_err("Failed to request DMA channel.\n");
goto acquire_err; goto acquire_err;
} }
@ -625,7 +625,8 @@ static int read_page_prepare(struct gpmi_nand_data *this,
length, DMA_FROM_DEVICE); length, DMA_FROM_DEVICE);
if (dma_mapping_error(dev, dest_phys)) { if (dma_mapping_error(dev, dest_phys)) {
if (alt_size < length) { if (alt_size < length) {
pr_err("Alternate buffer is too small\n"); pr_err("%s, Alternate buffer is too small\n",
__func__);
return -ENOMEM; return -ENOMEM;
} }
goto map_failed; goto map_failed;
@ -675,7 +676,8 @@ static int send_page_prepare(struct gpmi_nand_data *this,
DMA_TO_DEVICE); DMA_TO_DEVICE);
if (dma_mapping_error(dev, source_phys)) { if (dma_mapping_error(dev, source_phys)) {
if (alt_size < length) { if (alt_size < length) {
pr_err("Alternate buffer is too small\n"); pr_err("%s, Alternate buffer is too small\n",
__func__);
return -ENOMEM; return -ENOMEM;
} }
goto map_failed; goto map_failed;
@ -763,7 +765,7 @@ static int gpmi_alloc_dma_buffer(struct gpmi_nand_data *this)
error_alloc: error_alloc:
gpmi_free_dma_buffer(this); gpmi_free_dma_buffer(this);
pr_err("allocate DMA buffer ret!!\n"); pr_err("Error allocating DMA buffers!\n");
return -ENOMEM; return -ENOMEM;
} }
@ -1474,7 +1476,7 @@ static int gpmi_set_geometry(struct gpmi_nand_data *this)
/* Set up the NFC geometry which is used by BCH. */ /* Set up the NFC geometry which is used by BCH. */
ret = bch_set_geometry(this); ret = bch_set_geometry(this);
if (ret) { if (ret) {
pr_err("set geometry ret : %d\n", ret); pr_err("Error setting BCH geometry : %d\n", ret);
return ret; return ret;
} }