Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-12-24 20:01:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

dmaengine: ti: dma-crossbar: Fix a memory leak bug

Browse Source 
In ti_dra7_xbar_probe(), 'rsv_events' is allocated through kcalloc(). Then
of_property_read_u32_array() is invoked to search for the property.
However, if this process fails, 'rsv_events' is not deallocated, leading to
a memory leak bug. To fix this issue, free 'rsv_events' before returning
the error.

Signed-off-by: Wenwen Wang <wenwen@cs.uga.edu>
Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Link: https://lore.kernel.org/r/1565938136-7249-1-git-send-email-wenwen@cs.uga.edu
Signed-off-by: Vinod Koul <vkoul@kernel.org>
This commit is contained in:
Wenwen Wang 2019-08-16 01:48:55 -05:00 committed by Vinod Koul
parent d1abaeb3be
commit 2c231c0c1d
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/dma/ti/dma-crossbar.c
View File

@ -391,8 +391,10 @@ static int ti_dra7_xbar_probe(struct platform_device *pdev)
ret = of_property_read_u32_array(node, pname, (u32 *)rsv_events, ret = of_property_read_u32_array(node, pname, (u32 *)rsv_events,
nelm * 2); nelm * 2);
if (ret) if (ret) {
kfree(rsv_events);
return ret; return ret;
}
for (i = 0; i < nelm; i++) { for (i = 0; i < nelm; i++) {
ti_dra7_xbar_reserve(rsv_events[i][0], rsv_events[i][1], ti_dra7_xbar_reserve(rsv_events[i][0], rsv_events[i][1],