Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-12-04 18:13:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

clk: zx296718: do not panic on failure

Browse Source 
Instead of using panic, we should give an error message and return error
code when of_clk_add_hw_provider() call fails.

Since we have error prompt for failures, the "init over" pr_info output
isn't really necessary but becomes a debug noise.  So let's clean it up
along the way.

Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
This commit is contained in:
Shawn Guo 2016-12-16 15:26:45 +08:00 committed by Stephen Boyd
parent ed784c532a
commit 26f6b0b771
1 changed files with 18 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
drivers/clk/zte/clk-zx296718.c
View File

@ -610,9 +610,12 @@ static int __init top_clocks_init(struct device_node *np)
}
}
if (of_clk_add_hw_provider(np, of_clk_hw_onecell_get, &top_hw_onecell_data))
panic("could not register clk provider\n");
pr_info("top clk init over, nr:%d\n", TOP_NR_CLKS);
ret = of_clk_add_hw_provider(np, of_clk_hw_onecell_get,
&top_hw_onecell_data);
if (ret) {
pr_err("failed to register top clk provider: %d\n", ret);
return ret;
}
return 0;
}
@ -776,9 +779,12 @@ static int __init lsp0_clocks_init(struct device_node *np)
}
}
if (of_clk_add_hw_provider(np, of_clk_hw_onecell_get, &lsp0_hw_onecell_data))
panic("could not register clk provider\n");
pr_info("lsp0-clk init over:%d\n", LSP0_NR_CLKS);
ret = of_clk_add_hw_provider(np, of_clk_hw_onecell_get,
&lsp0_hw_onecell_data);
if (ret) {
pr_err("failed to register lsp0 clk provider: %d\n", ret);
return ret;
}
return 0;
}
@ -881,9 +887,12 @@ static int __init lsp1_clocks_init(struct device_node *np)
}
}
if (of_clk_add_hw_provider(np, of_clk_hw_onecell_get, &lsp1_hw_onecell_data))
panic("could not register clk provider\n");
pr_info("lsp1-clk init over, nr:%d\n", LSP1_NR_CLKS);
ret = of_clk_add_hw_provider(np, of_clk_hw_onecell_get,
&lsp1_hw_onecell_data);
if (ret) {
pr_err("failed to register lsp1 clk provider: %d\n", ret);
return ret;
}
return 0;
}